Re: [PATCH] PCI: altera: remove unused num_of_vectors variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 12, 2017 at 05:51:16PM +0800, Shawn Lin wrote:
> It was never used and could be removed, otherwise
> we could see a warning:
> 
> drivers/pci/host/pcie-altera-msi.c: In function 'altera_msi_isr':
> drivers/pci/host/pcie-altera-msi.c:67:6: warning: variable
> 'num_of_vectors' set but not used [-Wunused-but-set-variable]
> 
> Cc: Ley Foon Tan <lftan@xxxxxxxxxx>
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>

Applied to pci/host-altera for v4.14, thanks!

> ---
> 
>  drivers/pci/host/pcie-altera-msi.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/host/pcie-altera-msi.c b/drivers/pci/host/pcie-altera-msi.c
> index 4e5d628..2864030 100644
> --- a/drivers/pci/host/pcie-altera-msi.c
> +++ b/drivers/pci/host/pcie-altera-msi.c
> @@ -64,13 +64,11 @@ static void altera_msi_isr(struct irq_desc *desc)
>  	struct irq_chip *chip = irq_desc_get_chip(desc);
>  	struct altera_msi *msi;
>  	unsigned long status;
> -	u32 num_of_vectors;
>  	u32 bit;
>  	u32 virq;
>  
>  	chained_irq_enter(chip, desc);
>  	msi = irq_desc_get_handler_data(desc);
> -	num_of_vectors = msi->num_of_vectors;
>  
>  	while ((status = msi_readl(msi, MSI_STATUS)) != 0) {
>  		for_each_set_bit(bit, &status, msi->num_of_vectors) {
> -- 
> 1.9.1
> 
> 



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux