attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (3): [PATCH 1/3] PCI: pci-sysfs: constify attribute_group structures. [PATCH 2/3] PCI: pci-label: constify attribute_group structures. [PATCH 3/3] PCI: hotplug: constify attribute_group structures. drivers/pci/hotplug/rpadlpar_sysfs.c | 2 +- drivers/pci/pci-label.c | 4 ++-- drivers/pci/pci-sysfs.c | 10 +++++----- 3 files changed, 8 insertions(+), 8 deletions(-) -- 1.9.1