Re: [PATCH] pci: ftpci100: Make clocks compulsory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

[auto build test WARNING on pci/next]
[also build test WARNING on next-20170622]
[cannot apply to v4.12-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Linus-Walleij/pci-ftpci100-Make-clocks-compulsory/20170622-171211
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/pci/host/pci-ftpci100.c: In function 'faraday_pci_probe':
>> drivers/pci/host/pci-ftpci100.c:456:18: warning: passing argument 1 of 'ERR_PTR' makes integer from pointer without a cast [-Wint-conversion]
      return ERR_PTR(clk);
                     ^~~
   In file included from include/linux/io.h:24:0,
                    from drivers/pci/host/pci-ftpci100.c:15:
   include/linux/err.h:23:35: note: expected 'long int' but argument is of type 'struct clk *'
    static inline void * __must_check ERR_PTR(long error)
                                      ^~~~~~~
>> drivers/pci/host/pci-ftpci100.c:456:10: warning: return makes integer from pointer without a cast [-Wint-conversion]
      return ERR_PTR(clk);
             ^~~~~~~~~~~~
   drivers/pci/host/pci-ftpci100.c:464:18: warning: passing argument 1 of 'ERR_PTR' makes integer from pointer without a cast [-Wint-conversion]
      return ERR_PTR(clk);
                     ^~~
   In file included from include/linux/io.h:24:0,
                    from drivers/pci/host/pci-ftpci100.c:15:
   include/linux/err.h:23:35: note: expected 'long int' but argument is of type 'struct clk *'
    static inline void * __must_check ERR_PTR(long error)
                                      ^~~~~~~
   drivers/pci/host/pci-ftpci100.c:464:10: warning: return makes integer from pointer without a cast [-Wint-conversion]
      return ERR_PTR(clk);
             ^~~~~~~~~~~~

vim +/ERR_PTR +456 drivers/pci/host/pci-ftpci100.c

   440	
   441		host = pci_alloc_host_bridge(sizeof(*p));
   442		if (!host)
   443			return -ENOMEM;
   444	
   445		host->dev.parent = dev;
   446		host->ops = &faraday_pci_ops;
   447		host->busnr = 0;
   448		host->msi = NULL;
   449		p = pci_host_bridge_priv(host);
   450		host->sysdata = p;
   451		p->dev = dev;
   452	
   453		/* Retrieve and enable optional clocks */
   454		clk = devm_clk_get(dev, "PCLK");
   455		if (IS_ERR(clk))
 > 456			return ERR_PTR(clk);
   457		ret = clk_prepare_enable(clk);
   458		if (ret) {
   459			dev_err(dev, "could not prepare PCLK\n");
   460			return ret;
   461		}
   462		p->bus_clk = devm_clk_get(dev, "PCICLK");
   463		if (IS_ERR(p->bus_clk))
   464			return ERR_PTR(clk);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux