On Fri, Jun 16, 2017 at 11:21:00PM +0300, Serge Semin wrote: > On Fri, Jun 16, 2017 at 01:34:59PM -0600, Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote: > > Now, if you'd like to actually review the code I'd be happy to address > > any concerns you find. I won't be responding to any more philosophical > > arguments or bike-shedding over the format of the patch. > > > > I don't want to review a patchset, which isn't properly formated. Ah, but the patchset does seem to properly formatted. At least it's easy for me to review as-published, while a much smaller number of patches, making much larger individual patches, would be much much harder to review. But what do I know... Oh wait, I review more kernel patches than anyone else :) Logan, given that you need to rebase these on the "new" ntb api (and why the hell is that tree on github? We can't take kernel git pulls from github), is it worth reviewing this patch series as-is, or do you want us to wait? thanks, greg k-h
