On 07/06/17 23:34, Mason wrote: > Hello Rob, > > On 07/06/2017 23:29, Rob Herring wrote: >> On Wed, May 31, 2017 at 03:30:26PM +0200, Marc Gonzalez wrote: >>> Binding for the Sigma Designs SMP8759 SoC. >>> >>> Signed-off-by: Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/pci/tango-pcie.txt | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/tango-pcie.txt b/Documentation/devicetree/bindings/pci/tango-pcie.txt >>> new file mode 100644 >>> index 000000000000..35ef2c811a27 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/pci/tango-pcie.txt >>> @@ -0,0 +1,30 @@ >>> +Sigma Designs Tango PCIe controller >>> + >>> +Required properties: >>> + >>> +- compatible: "sigma,smp8759-pcie" >>> +- reg: address/size of PCI configuration space, address/size of register area >>> +- device_type: "pci" >>> +- #size-cells: <2> >>> +- #address-cells: <3> >>> +- msi-controller >>> +- ranges: translation from system to bus addresses >>> +- interrupts: spec for misc interrupts, spec for MSI >>> + >>> +http://elinux.org/Device_Tree_Usage#PCI_Address_Translation >>> +http://elinux.org/Device_Tree_Usage#Advanced_Interrupt_Mapping >> >> Why are these here? > > I found these references very helpful when writing the node. > Where would you put them? In the example? I don't think they belong in this document at all. Thanks, M. -- Jazz is not dead. It just smells funny...
