Joao, On 06/05/2017 12:19 PM, Joao Pinto wrote: > This patch series adds the new interrupt api to pcie-designware > make it possible to use features like MSIX. > > The work consisted of adapting the pcie-designware-host and each SoC > specific driver. > > The patch set was made against the Bjorn' next branch. > > Joao Pinto (9): > pci: adding new irq api to pci-designware > pci: exynos SoC driver adapted to new irq API > pci: imx6 SoC driver adapted to new irq API > pci: artpec6 SoC driver adapted to new irq API > pci: generic PCIe DW driver adapted to new irq API > pci: qcom SoC driver adapted to new irq API > pci: keystone SoC driver adapted to new irq API > pci: removing old irq api from pcie-designware > pci: remove limitation of the number of the available IRQs > > drivers/pci/dwc/pci-exynos.c | 18 -- > drivers/pci/dwc/pci-imx6.c | 18 -- > drivers/pci/dwc/pci-keystone-dw.c | 96 +------- > drivers/pci/dwc/pci-keystone.c | 1 + > drivers/pci/dwc/pci-keystone.h | 4 +- > drivers/pci/dwc/pci-layerscape.c | 4 +- > drivers/pci/dwc/pcie-artpec6.c | 18 -- > drivers/pci/dwc/pcie-designware-host.c | 395 +++++++++++++++++++-------------- > drivers/pci/dwc/pcie-designware-plat.c | 15 -- > drivers/pci/dwc/pcie-designware.h | 30 ++- > drivers/pci/dwc/pcie-qcom.c | 15 -- > 11 files changed, 255 insertions(+), 359 deletions(-) > I gave this a try today and it failed. Logs at http://pastebin.ubuntu.com/24843963/ The first part of the log is with your patch series. The second part is before applying the patch. You will see that there is qc timeout log that shows the issue [ 12.791852] ata2.00: qc timeout (cmd 0xec) [ 12.795947] ata2.00: failed to IDENTIFY (I/O error, err_mask=0x4) [ 12.802061] ata2: limiting SATA link speed to 3.0 Gbps [ 13.301853] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 320) [ 23.511852] ata2.00: qc timeout (cmd 0xec) [ 23.515947] ata2.00: failed to IDENTIFY (I/O error, err_mask=0x4) [ 24.021850] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 320) Is there any DT change I need to make for this? I didn't have a chance to review your patch w.r.t Keystone. But I see you have change the MSI IRq handling. -- Murali Karicheri Linux Kernel, Keystone
