On Wed, Jun 7, 2017 at 9:19 AM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > CC pci folks > > On Wed, Jun 7, 2017 at 12:59 AM, Palmer Dabbelt <palmer@xxxxxxxxxxx> wrote: >> While upstreaming the RISC-V port, it was pointed out that multiple >> architectures (arc, arm64, cris, microblaze, sh, tile) have copied the >> mostly empty versions of at least one of these functions. This defines >> weakly bound versions of the common functions so other architetures can >> use them. >> >> Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxx> Thanks a lot for taking care of this! >> diff --git a/drivers/pci/bios.c b/drivers/pci/bios.c >> new file mode 100644 >> index 000000000000..ffe34c024aa8 >> --- /dev/null >> +++ b/drivers/pci/bios.c >> @@ -0,0 +1,42 @@ >> + >> +/* This file contains weakly bound functions that implement pcibios functions >> + * that some architectures have copied verbatim. >> + */ Instead of adding a new file, I would suggest adding the two functions next to their callers, in probe.c and setup-res.c, respectively. Arnd