On Tue, May 23, 2017 at 8:39 PM, songxiaowei <songxiaowei@xxxxxxxxxxxxx> wrote: > -----邮件原件----- > 发件人: Rob Herring [mailto:robh@xxxxxxxxxx] > 发送时间: 2017年5月23日 22:17 > 收件人: songxiaowei > 抄送: Wangzhou (B); Gabriele Paoloni; bhelgaas@xxxxxxxxxx; mark.rutland@xxxxxxx; xuwei (O); catalin.marinas@xxxxxxx; will.deacon@xxxxxxx; linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Chenfeng (puck); guodong.xu@xxxxxxxxxx; Wangbinghui; Suzhuangluan > 主题: Re: [Patch v3 1/3] arm64: dts: hi3660: add pcie node > > On Thu, May 18, 2017 at 03:49:46PM +0800, Song Xiaowei wrote: >> Add PCIe node for hi3660, and add binding documentation. >> >> Cc: Guodong Xu <guodong.xu@xxxxxxxxxx> >> Signed-off-by: Song Xiaowei <songxiaowei@xxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/pci/hisilicon-pcie.txt | 52 ++++++++++++++++++++++ >> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 31 +++++++++++++ [...] >> + "config": PCIe configuration space registers. >> +- reset-gpio: perst assert/deassert gpio > > reset-gpios > [songxiaowei] rest-gpio is used to signal 'pcie perst': high level refers to deassert > and low level refers to assert. So, I think ' reset-gpio: creates perst assert/deassert signal ' > would be a better choice. What I was saying is the name should be reset-gpios, not reset-gpio. Rob
