Hi Bjorn, On Tuesday 23 May 2017 02:56 AM, Bjorn Helgaas wrote: > On Tue, May 16, 2017 at 07:21:08PM +0200, Geert Uytterhoeven wrote: >> If NO_DMA=y: >> >> drivers/built-in.o: In function `__pci_epc_create': >> (.text+0xef4e): undefined reference to `bad_dma_ops' >> drivers/built-in.o: In function `pci_epc_add_epf': >> (.text+0xf676): undefined reference to `bad_dma_ops' >> drivers/built-in.o: In function `pci_epf_alloc_space': >> (.text+0xfa32): undefined reference to `bad_dma_ops' >> drivers/built-in.o: In function `pci_epf_free_space': >> (.text+0xfac4): undefined reference to `bad_dma_ops' >> >> Add a dependency on HAS_DMA to fix this. >> >> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Applied to for-linus for v4.12, thanks! > >> --- >> Should PCI_ENDPOINT depend on CONFIG_PCI instead? > > I *think* we want HAS_DMA, not CONFIG_PCI, because CONFIG_PCI means we > want the infrastructure for PCI host bridges, enumerating children of > the bridges, etc. I think we want to allow PCI_ENDPOINT without all > that. > > Kishon? right. CONFIG_PCI is for enabling the host infrastructure and PCI_ENDPOINT and CONFIG_PCI should be completely independent of each other. Thanks Kishon
