Re: [RFC] pci: adding new interrupt api to pcie-designware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Murali,

On 12/05/17 17:05, Murali Karicheri wrote:
> On 05/11/2017 06:05 AM, Marc Zyngier wrote:
>> On 11/05/17 10:17, Joao Pinto wrote:
>>>
>>> Hello,
>>>
>>> Às 6:00 PM de 5/10/2017, Marc Zyngier escreveu:
>>>> On 09/05/17 13:33, Joao Pinto wrote:
>>>>> This is a proposal for the update of the interrupt API in pcie-designware.
>>>>>
>>>>> *SoC specific drivers*
>>>>> All SoC specific drivers that use the common infrastructure (pci-qcom,
>>>>> pci-artpec6, pci-exynos, pci-imx6) were updated to be compatible.
>>>>> Other SoC specific drivers like pci-dra7, pci-armada8k, pci-hisi, pci-spear13xx
>>>>> and pci-layerscape will also work fine.
>>>>>
>>>>> *Work still to be done - need some inputs*
>>>>> The pci-keystone driver is the one that I would appreciate some opinions, since
>>>>> it uses the "old" dw_pcie_msi_chip. I think we have 3 options:
>>>>>
>>>>> a) Keep the old API + new API in pcie-designware just for pci-keystone to use
>>>>> the dw_pcie_msi_chip structure
>>>>> b) Move the old API from pcie-designware to pci-keystone for it to use the
>>>>> dw_pcie_msi_chip structure
>>>>> c) Adapt pci-keystone to use the new API also
>>>>
>>>> What is the issue with moving Keystone over to this infrastructure?
>>>
>>> I don't hardware to test if the Keystone infrastructure porting is right or not
>>> and thats my main concern. Also the Keystone SoC driver maintainer can also have
>>> the option of keeping the current structure and that's why I sent the e-mail
>>> asking for opinions about the subject.
>>
>> I think the old infrastructure should disappear, full stop (maintaining
>> two APIs is hell). It'd be great if you could convert it as well,
>> leaving the testing responsibility to the TI guys who I'm sure will
>> gladly help (they've done so in the past for different things).
> Marc,
> 
> Sure! I can help you on the testing part. I haven't had a chance to read this
> patch due to my current tasks, but will spend some time on this next week.

Awesome! Please liaise with Joao in order to get this up and running!

Thanks both,

	M.
-- 
Jazz is not dead. It just smells funny...



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux