On Thu, Apr 20, 2017 at 12:14 PM, Sinan Kaya <okaya@xxxxxxxxxxxxxx> wrote: > On 4/18/2017 8:31 PM, Yinghai Lu wrote: >> * pci_setup_device - fill in class and map information of a device >> * @dev: the device structure to fill >> @@ -1572,6 +1592,9 @@ int pci_setup_device(struct pci_dev *dev >> /* device class may be changed after fixup */ >> class = dev->class >> 8; >> >> + if (is_kdump_kernel()) >> + pci_disable_serr(dev); >> + > > This sounds like something that needs to be done while shutting down > the first kernel as part of the kdump procedure rather than boot of > the kdump kernel in pci setup. In general, I would rather make the new kernel more tolerant than make assumptions about how the old kernel shut down. I don't know if there's an explicit statement of kexec philosophy on this (it'd be nice if there were), but it seems like a more robust strategy, e.g., less prone to revlock issues between the old/new kernels. Bjorn
