Hi Bjorn, On Tue, Apr 04, 2017 at 11:43:11AM -0500, Bjorn Helgaas wrote: > > +static const struct pci_device_id broken_ats_tbl[] = { > > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, 0x98e4) }, /* AMD Stoney GPU part */ Just found out that the affected GPU uses PCI_VENDOR_ID_ATI, fixed that too. > > + { 0 } > > +}; > > + > > void pci_ats_init(struct pci_dev *dev) > > > > int pos; > > > > + if (pci_match_id(broken_ats_tbl, dev)) > > + return; > > This is fine functionally, but from a stylistic point of view, I guess > I would prefer to have it implemented in drivers/pci/quirks.c just to > have some consistency in how we work around device defects. Done, I send a new patch shortly. Joerg