Hi Sinan, > >Hi Mayurkumar, > >On 4/6/2017 9:23 AM, Patel, Mayurkumar wrote: >> The patch seems to be working for ASPM L1 so far. I am seeing a problem now with your patches for L1.2 as following: >> >> ASPM L1.2 does not get enabled on the Upstream as well as downstream port due to following reasons. >> In the case, I see now, if the EP is not connected while reboot of the Machine, Root Port does not configure >> It's own L1.2 also from the BIOS. (I am not sure whether it's even advisable to enable L1.2 on root >> Port when no downstream device is not connected to it as it may have an impact on CLKREQ# and device is connected >> At later stage may have a problem with it) >> > >I have two questions: > >1. if the endpoint is connected during boot and have ASPM L1.2 enabled during boot, >do you see that L1.2 gets re-enabled following a hotplug remove and then insert. >This is the goal of this patch. If yes, we achieved our goal. This is working on >my platform but I do not have L1SS support on my platform. > Yes this works fine if the EP is connected during platform boot up and I could see the L1SS enabled. >2. if you do not connect any endpoint during boot and insert the card, do you >see any ASPM enabled at all with and without my patch using the default policy? >I think this is the part you are describing above. I'll confirm this on my platform >too. I think this one will require another patch/discussion unless I broke something. > Actually, without your patches, I see during boot if EP is connected then L1SS are enabled. Also, if EP is connected afterwards, L1SS are enabled. But behavior is as previously, that It gets disabled due to POLICY_DEFAULT bug and does not stay consistent following next power cycle of Endpoint. > >> Later when the Device get connected, BIOS configures L1.2 for Root port and EP but due to policy set to incorrect, >> Kernel disables ASPM L1.2. > >Sinan > >-- >Sinan Kaya >Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. >Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928
