> > > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > > + if (!p2pmem_debugfs_root) > > + pr_info("could not create debugfs entry, continuing\n"); > > + > > Why continue? I think it'd be better to just fail it. > Because not having debugfs support isn't fatal to using p2pmem. So I believe it is better to continue. But this is trivial, IMO, so either was is ok with me. > Besides, this can be safely squashed into patch 1. Yes.