Re: [PATCH 5/5] PCI: remove pci_enable_msix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/30/2017 03:56 PM, Bjorn Helgaas wrote:
On Tue, Mar 28, 2017 at 09:24:15AM -0700, David Daney wrote:
On 03/27/2017 11:41 PM, Christoph Hellwig wrote:
On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote:
Use pci_enable_msix_{exact,range} for now, as I told you before.


That still results in twice as many MSI-X being provisioned than are needed.

How so?  Except for the return value, a pci_enable_msix_exact call with the
same arguments as your previous pci_enable_msix will work exactly the
same.


Sorry, I think it was my misunderstanding.  I didn't realize that we
had essentially renamed the function, but left the functionality
mostly unchanged.

Does this mean you're OK with this patch?

Yes. I have re-written my GPIO driver to use the newer functions, so I withdraw my objections to the patch.

Thanks,
David Daney


I know it may require some
work on out-of-tree drivers and so on, but if that work is possible
and you don't actually lose functionality, I'm OK with this patch.

Bjorn





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux