On Thu, Mar 09, 2017 at 04:59:15PM +0800, Shawn Lin wrote: > On 2017/3/9 7:37, Brian Norris wrote: > >The regulator framework can return negative error codes via > >regulator_get_current_limit() for regulators that don't provide current > >information. The subsequent check for postive values isn't very useful, > >if the variable is unsigned. > > > >Let's just match the signedness of the return value. > > > >Prevents error messages like this, seen on Samsung Chromebook Plus: > > > >[ 1.069372] rockchip-pcie f8000000.pcie: invalid power supply > > > > For this patch, > > Acked-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> Thanks. > And I think patch 2 is not so urgent so we could just wait for your > non-WIP patch 3? Sure. I'll be resending the series with a proper patch 3 (and 4 and 5 actually) soon anyway. No changes to the first 2. Brian
