> -----Original Message----- > From: Christoph Hellwig [mailto:hch@xxxxxx] > Sent: Wednesday, March 1, 2017 7:21 AM > To: Madhani, Himanshu <Himanshu.Madhani@xxxxxxxxxx> > Cc: bhelgaas@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; hch@xxxxxx > Subject: Re: [PATCH] PCI/MSI: Only disable affinity settings if pre and post > vector count is equal to max_vecs and not min_vecs > > > @@ -1206,16 +1228,6 @@ int pci_alloc_irq_vectors_affinity(struct pci_dev > *dev, unsigned int min_vecs, > > if (flags & PCI_IRQ_AFFINITY) { > > if (!affd) > > affd = &msi_default_affd; > > - > > - if (affd->pre_vectors + affd->post_vectors > min_vecs) > > - return -EINVAL; > > Actually I think we can leave this check here. > > > - > > - /* > > - * If there aren't any vectors left after applying the pre/post > > - * vectors don't bother with assigning affinity. > > - */ > > - if (affd->pre_vectors + affd->post_vectors == min_vecs) > > - affd = NULL; > > And only move this one down into the allocator helpers. Will send out update soon. Thanks, Himanshu
