On Tue, Jan 31, 2017 at 1:37 AM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > Looks nice; a couple unused definitions below. Just so I do things right: what is your policy on unused defines? I'm asking because the defines in this case is pretty much the documentation... there is no datasheet for this IP core. I usually like to keep the defines around so people can have them as a hint if they want to tinker and hack the driver. Would you be OK with keeping them if I comment them out? I'll repost the driver soon, including all things asked to be fixed up by you & Arnd. Yours, Linus Walleij
