Re: [PATCH] PCI: altera: Fix TLP completion status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 17, 2017 at 08:27:10AM +0800, Yadi Hu wrote:
> From: "Hu Yadi" <yadi.hu@xxxxxxxxxxxxx>
> 
> the driver does not use exactly 'Completion Status' value in TLP,
> these bits should be b15:13 not b14:12.
> 
> Signed-off-by: Hu Yadi<yadi.hu@xxxxxxxxxxxxx>

Applied with Ley Foon's ack to pci/host-altera for v4.11, thanks.

BTW, the patch was apparently built against an old kernel (pre-v4.9), so it
didn't apply directly.  But I applied it by hand.

> ---
>  drivers/pci/host/pcie-altera.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c
> index dbac6fb..650862e 100644
> --- a/drivers/pci/host/pcie-altera.c
> +++ b/drivers/pci/host/pcie-altera.c
> @@ -56,7 +56,7 @@
>  #define TLP_CFG_DW2(bus, devfn, offset)	\
>  				(((bus) << 24) | ((devfn) << 16) | (offset))
>  #define TLP_REQ_ID(bus, devfn)		(((bus) << 8) | (devfn))
> -#define TLP_COMP_STATUS(s)		(((s) >> 12) & 7)
> +#define TLP_COMP_STATUS(s)		(((s) >> 13) & 7)
>  #define TLP_HDR_SIZE			3
>  #define TLP_LOOP			500
>  #define RP_DEVFN			0
> -- 
> 2.9.3
> 



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux