On Mon, Feb 06, 2017 at 09:33:00AM -0800, Christoph Hellwig wrote: > On Fri, Feb 03, 2017 at 12:55:52PM -0500, Keith Busch wrote: > > +static inline int pci_dev_set_disconnected(struct pci_dev *dev, void *unused) > > +{ > > + set_bit(PCI_DEV_DISCONNECTED, &dev->priv_flags); > > + return 0; > > +} > > Return void here? This is used as the callback to pci_walk_bus for setting downstream device disconnect state in case a switch was hot removed, so I have to respect the prototype's 'int' return and the "unused" data parameter. I'll fix up the long lines.