Re: [PATCH] PCI/MSI: don't apply affinity if there aren't enough vectors left

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 02, 2017 at 11:36:59AM -0600, Bjorn Helgaas wrote:
> You didn't say exactly where the out of bounds access was, but I assume
> it's probably in irq_create_affinity_masks() in this path:

Yes.  See the original report from Bart here:

http://www.spinics.net/lists/linux-scsi/msg104082.html

> The fix in pci_alloc_irq_vectors_affinity() looks fine, but I wish it
> were closer to the actual problem.

I plan to also fix the low-level issue, but:

 a) I have other patches pending in that are for 4.11 and I'd like
    to batch them up with those to avoid conflicts
 b) we really need a high-level check like the one added in this
    patch so that we do the right thing (drop affinity) in this
    case instead of returning an error to the caller and failing
    the probe.




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux