Hi Bjorn, On Sat, Jan 28, 2017 at 03:17:28PM -0600, Bjorn Helgaas wrote: > On Wed, Jan 11, 2017 at 12:30:55PM -0600, Bjorn Helgaas wrote: > > On Mon, Dec 12, 2016 at 11:30:20AM -0700, Jason Gunthorpe wrote: > > > The PCI core will write to the bridge window config multiple times > > > while they are enabled. This can lead to mbus failures like: > > > > > > mvebu_mbus: cannot add window '4:e8', conflicts with another window > > > mvebu-pcie mbus:pex@e0000000: Could not create MBus window at [mem 0xe0000000-0xe00fffff]: -22 > > > > > > For me this is happening during a hotplug cycle. The PCI core is > > > not changing the values, just writing them twice while active. > > > > > > The patch addresses the general case of any change to an active window, > > > but not atomically. The code is slightly refactored so io and mem > > > can share more of the window logic. > > > > Looks good to me, but I'm waiting for an ack from Thomas or Jason (listed > > as maintainers and already cc'd). > > Ping, Thomas, Jason C? > > > > Signed-off-by: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> > > > --- > > > drivers/pci/host/pci-mvebu.c | 101 +++++++++++++++++++++++++------------------ > > > 1 file changed, 60 insertions(+), 41 deletions(-) Sorry, been on travel and I think Thomas is on holiday. Acked-by: Jason Cooper <jason@xxxxxxxxxxxxxx> thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
