* Kishon Vijay Abraham I <kishon@xxxxxx> [170115 22:06]: > Hi Tony, > > On Friday 13 January 2017 10:45 PM, Tony Lindgren wrote: > > * Kishon Vijay Abraham I <kishon@xxxxxx> [170112 02:35]: > >> The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should > >> be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO > >> in RC mode. However in EP mode, the host system is not able to access the > >> MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. > > > > I guess ideally in the long run we would set this dynamically based on > > the selected mode, right? > > The programming sequence mentioned in the TRM w.r.t clock programming is same > for both host mode or device mode. Though we never faced any issues in host > mode when HW_AUTO is set, it's better to follow TRM recommended settings IMHO. OK best to merge this with the whole series: Acked-by: Tony Lindgren <tony@xxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html