Hi Leon, On 01/10/2017 11:12 PM, Leon Romanovsky wrote: > Can't you recognize such device at the initialization phase? Yes, this is exactly what it does. It checks the device GUID and reorders the ports during insmod. > This is definitely specific HW implementation bug/issue/limitation. Correct. As the commit message says this is to fix a HW issue. > > I always had an impression that module parameters are rarely beneficial > in upstream kernel for driver modules and adding them for new driver > code should be explicitly prohibited in CodingStyle guide. > > You are adding new module parameter which will be with us forever to fix > special HW bug/implementation in some legacy installations. It will be > insane to add such thing to upstream kernel, errata and out-of-tree > implementations are best places for such things. Agree, but the reality is that there are 5505 $(git grep module_param drivers/ | wc -l) module parameters in the kernel already, and even mlx4 and mlx5 drivers use them. I really considered every other possible solution, but module parameter is the only possible way to do such things during insmod. Thanks, -- Tadeusz -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
