Re: [RFC PATCH] ACPI/PCI: Fix bus range comparation in pci_mcfg_lookup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017/1/3 14:39, Tomasz Nowicki wrote:
> On 22.12.2016 10:07, Zhou Wang wrote:
>> Multiple PCIe host bridges may exists in one PCIe segment. So bus range for each
>> host bridge should be in the coverage of bus range of related PCIe segment.
>>
>> This patch will support this kind of scenario:
>>
>> MCFG:
>>     bus range: 0x00~0xff.
>>     segment: 0.
>> DSDT:
>>     host bridge 1:
>>         bus range: 0x00~0x1f.
>>         segment: 0.
>>     host bridge 2:
>>         bus range: 0x20~0x4f.
>>         segment: 0.
>>
>> Signed-off-by: Zhou Wang <wangzhou1@xxxxxxxxxxxxx>
>> ---
>>  drivers/acpi/pci_mcfg.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c
>> index b5b376e..46a3e32 100644
>> --- a/drivers/acpi/pci_mcfg.c
>> +++ b/drivers/acpi/pci_mcfg.c
>> @@ -40,11 +40,10 @@ phys_addr_t pci_mcfg_lookup(u16 seg, struct resource *bus_res)
>>      struct mcfg_entry *e;
>>
>>      /*
>> -     * We expect exact match, unless MCFG entry end bus covers more than
>> -     * specified by caller.
>> +     * We expect the range in bus_res in the coverage of MCFG bus range.
>>       */
>>      list_for_each_entry(e, &pci_mcfg_list, list) {
>> -        if (e->segment == seg && e->bus_start == bus_res->start &&
>> +        if (e->segment == seg && e->bus_start <= bus_res->start &&
>>              e->bus_end >= bus_res->end)
>>              return e->addr;
>>      }
>>
> 
> Looks good to me.
> 
> Reviewed-by: Tomasz Nowicki <tn@xxxxxxxxxxxx>

Hi Tomasz,

Thanks for your review.

Regards,
Zhou

> 
> Thanks,
> Tomasz
> 
> .
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux