Dear Jingoo, On 12/26/2016 11:43 PM, Jingoo Han wrote: > Jaehoon Chung wtote: >> >> Hi Pankaj, >> >> On 12/23/2016 07:56 PM, Pankaj Dubey wrote: >>> From: Niyas Ahmed S T <niyas.ahmed@xxxxxxxxxxx> >>> >>> Currently Exynos PCIe driver is only supported for Exynos5440 SoC. >>> This patch does refactoring of Exynos PCIe driver to extend support >>> for other Exynos SoC. >>> >>> Following are the main changes done via this patch: >>> 1) It adds separate structs for memory, clock resources. >>> 2) It add exynos_pcie_ops struct which will allow us to support the >>> differences in resources in different Exynos SoC. >> >> It's nice to me for reusing this file. >> but after considering too many times, i decided not to use this file. >> >> I'm not sure what block base is..actually this pci-exynos.c is really >> black-box. >> (No one maintains this file, even Samsung didn't care.) >> Who is using this? >> If Someone can share the information about exynos5440, i can refactor >> everything. >> Otherwise, there are two solution.. >> >> One is "adding the new pci-exynos.c" likes pci-exynos5433.c > > As Bjorn mentioned earlier, I agree with this option. > >> Other is "refactor this file" under assuming the each register's usage. > > But, if possible, I prefer this option. > I am not sure that it cannot make the code dirty. > Maybe, you need to discuss with hardware design engineers. > >> >> I want to use the PHY generic Framework for EXYNOS PCIe. >> >> If you or other guys really want to use the pci-exynos.c for other exynos, >> I will rework with PHY generic framework. Then i will resend the my >> patches as V2. > > When I submitted the pci-exynos.c, there was no PHY generic framework. > But, currently, using PHY generic framework is mandatory, as other PCIe host > driver did. > I think that we should use PHY generic framework for new SoCs. > >> >> One more thing..Does anyone know what the usage of block base is? >> Can i use that register as "syscon"? > > 'Block' is very specific registers for 5440. > Other Exynos SoCs do not use that registers. > Actually, it is not the same with 'syscon'. > But, you can assume 'block' as 'syscon'. Great! I want to know it. Then i will refactor this file for all other Exynos SoCs. And Could you check my RFC patches? Maybe i missed your email in my RFC patches. https://lkml.org/lkml/2016/12/26/6 Best Regards, Jaehoon Chung > > Best regards, > Jingoo Han > >> >> Best Regards, >> Jaehoon Chung >> > [.....] > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
