On Thu, Dec 22, 2016 at 06:54:51AM +0100, John Crispin wrote: > On 21/12/2016 15:26, Christoph Hellwig wrote: > > On Wed, Dec 21, 2016 at 02:11:25PM +0100, John Crispin wrote: > >> I can turn it into an enable patch that is selected by default. > >> > >> The current patch disables all those quirks that are used for x86/PC > >> style machines and hence are not required in the embedded world. > > > > Maybe we'll just need to reorganize the quirks so that most of them > > arch in arch code or the affected drivers? > > to be honest i have no opinion on this. I am currently trying to reduce > the amount of patches that we have inside the LEDE tree. the patches > were written by other people and then dumped on us. obviously i am > interested to get this upstream with the least amount of effort. I am > quite aware though that some patches will need an overhaul to be > applicable for upstream. its not really my call if it is enough to make > this an enable patch and review the quirks enabled by it or if the code > needs to be moved. We already have CONFIG_PCI_QUIRKS, which enables everything in drivers/pci/quirks.c. That file should contain quirks for devices that may appear on any architecture, e.g., things on plug-in cards. Quirks that are only applicable to one arch should be in the arch directory, e.g., in arch/x86/pci/fixup.c. If drivers/pci/quirks.c contains arch-specific quirks, we should move those to the appropriate arch directory. It looks like arch/x86/pci/fixup.c is currently compiled unconditionally (on x86 with PCI), but we should probably make it dependent on CONFIG_PCI_QUIRKS, since I think the infrastructure that *calls* those quirks is only present when CONFIG_PCI_QUIRKS=y. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
