[+cc linux-pci, Linas] On Mon, Dec 19, 2016 at 03:23:56PM +0800, Cao jin wrote: > In AER recovery, pci_error_handlers.link_reset() is never called, > drop it now. I think it's true that .link_reset() is never called. If that's the case, why not remove it completely, i.e., remove it from struct pci_error_handlers and from all the other drivers that supply it? > Signed-off-by: Cao jin <caoj.fnst@xxxxxxxxxxxxxx> > --- > drivers/misc/genwqe/card_base.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c > index 6c1f49a85023..4fd21e86ad56 100644 > --- a/drivers/misc/genwqe/card_base.c > +++ b/drivers/misc/genwqe/card_base.c > @@ -1336,7 +1336,6 @@ static int genwqe_sriov_configure(struct pci_dev *dev, int numvfs) > static struct pci_error_handlers genwqe_err_handler = { > .error_detected = genwqe_err_error_detected, > .mmio_enabled = genwqe_err_result_none, > - .link_reset = genwqe_err_result_none, > .slot_reset = genwqe_err_slot_reset, > .resume = genwqe_err_resume, > }; > -- > 2.1.0 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html