Hi Bjorn Thanks. I have resent the last patch again with consistent lock usage as you had requested. I did attempt to make things a bit more easier to understand in one my earlier experiments, but that resulted in very substantial changes. Certainly something we should look in future to make the state machine more robust. Cheers, Ashok On Thu, Dec 08, 2016 at 11:50:09AM -0600, Bjorn Helgaas wrote: > > Yes, the alloc_ordered_workqueue is what I had in mind, though switching > > to that is not as simple as calling the different API. I am looking into > > that for longer term, but for the incremental fix, do you think we can > > go forward with Raj's proposal? > > I'd like to at least see a consistent locking strategy for protecting > p_slot->state. All the existing updates are protected by > p_slot->lock, but the one Raj is adding is protected by > p_slot->hotplug_lock. > > Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
