On 18/11/16 16:00, Will Deacon wrote: > On Wed, Nov 16, 2016 at 03:29:32PM +0000, Lorenzo Pieralisi wrote: >> Current ARM SMMU probe functions intermingle HW and DT probing >> in the initialization functions to detect and programme the ARM SMMU >> driver features. In order to allow probing the ARM SMMU with other >> firmwares than DT, this patch splits the ARM SMMU init functions into >> DT and HW specific portions so that other FW interfaces (ie ACPI) can >> reuse the HW probing functions and skip the DT portion accordingly. >> >> This patch implements no functional change, only code reshuffling. >> >> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> >> Reviewed-by: Tomasz Nowicki <tn@xxxxxxxxxxxx> >> Tested-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx> >> Tested-by: Tomasz Nowicki <tn@xxxxxxxxxxxx> >> Cc: Will Deacon <will.deacon@xxxxxxx> >> Cc: Hanjun Guo <hanjun.guo@xxxxxxxxxx> >> Cc: Robin Murphy <robin.murphy@xxxxxxx> >> --- >> drivers/iommu/arm-smmu.c | 62 +++++++++++++++++++++++++++++------------------- >> 1 file changed, 37 insertions(+), 25 deletions(-) > > Reviewed-by: Will Deacon <will.deacon@xxxxxxx> > > Although I'd also like Robin to have a look at this. Sorry, I've been slow this week. Having finally got round to taking a proper look, I swear this seems even tidier than the last version I looked at closely. It doesn't break DT boot on my Juno, either. Reviewed-by: Robin Murphy <robin.murphy@xxxxxxx> > > Will > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html