On Tue, Sep 27, 2016 at 04:23:32PM -0400, Keith Busch wrote: > This adds a new state for devices that were once in the system, but > unexpectedly removed. This is so device tear down functions can observe > the device is not accessible so it may skip attempting to initialize > the hardware. > > The pciehp and pcie-dpc drivers are aware of when the link is down, > so these explicitly set this flag when its handlers detect the device > is gone. I note that you've removed the change to pci_device_is_present() completely from v3 of this patch, however only a portion of the change was problematic. This portion would have been okay: + if (pdev->is_removed) + return false; return pci_bus_read_dev_vendor_id(pdev->bus, pdev->devfn, &v, 0); Up to you if you want to include this in the next iteration or not. Thanks, Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html