On Tue, 2016-10-11 at 10:37 +0200, Ingo Molnar wrote: > * Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > > On Sun, 2016-10-09 at 14:46 +0200, Lukas Wunner wrote: > > > > > > Commit cc7cc02bada8 ("PCI: Query platform firmware for device > > > power > > > state") augmented struct pci_platform_pm_ops with a ->get_state > > > hook > > > and > > > implemented it for acpi_pci_platform_pm, the only > > > pci_platform_pm_ops > > > existing till v4.7. > > > > > > However v4.8 introduced another pci_platform_pm_ops for Intel > > > Mobile > > > Internet Devices with commit 5823d0893ec2 ("x86/platform/intel- > > > mid: > > > Add > > > Power Management Unit driver"). It is missing the ->get_state > > > hook, > > > which is fatal since pci_set_platform_pm() enforces its presence. > > > > > > Retrofit mid_pci_platform_pm with the missing callback to fix the > > > breakage. > > > > > > > +Ingo. > > > > I guess it should go via tip/x86/urgent tree. > > Can do, if Bjorn is fine with it as well - the patch is touching > drivers/pci/pci-mid.c. Bjorn, we are at 4.9-rc1 already and it has this regression. Can you, please, ACK it? -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html