Re: [PATCH v2 0/5] PCI: iproc: Cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjorn,

On 10/12/2016 9:18 AM, Bjorn Helgaas wrote:
On Wed, Oct 12, 2016 at 09:04:26AM -0700, Ray Jui wrote:
Hi Bjorn,

On 10/12/2016 9:01 AM, Bjorn Helgaas wrote:
On Wed, Oct 12, 2016 at 07:53:03AM -0500, Bjorn Helgaas wrote:
 - Add local "dev" pointers to reduce repetition of things like
   "&pdev->dev".

 - Tidy up drvdata usage.

 - Remove some null pointer checking after adding corresponding checking
   elsewhere.

 - Hard-code the PCIe capability offset instead of searching for it.  This
   removes a little bit of dependency on struct pci_bus, with an eye
   toward moving the link maintenance before enumeration.

Changes from v1:
 I dropped the following patches because they were a lot of churn for
 questionable benefit:
   PCI: iproc: Rename accessors
   PCI: iproc: Name private struct pointer "iproc" consistently

---

Bjorn Helgaas (5):
     PCI: iproc: Add local struct device pointers
     PCI: iproc: Set drvdata at end of probe function
     PCI: iproc: Validate CSR base in BCMA setup code
     PCI: iproc: Remove redundant null pointer checking
     PCI: iproc: Hard-code PCIe capability offset instead of searching

I applied these to pci/host-iproc for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.


That sounds good. Are these patches in the git repo:
git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git at
branch pci/host-iproc?

They should be there.  I also just merged everything into my "next"
branch.

I plan to sanity test them on various iProc based SoCs.

Great, thanks!


I sanity tested the following patches through v4.9-rc1 on both ARM32 and ARM64, iProc based platforms (i.e., Cygnus and NS2):

PCI: iproc: Hard-code PCIe capability offset instead of searching
PCI: iproc: Remove redundant null pointer checking
PCI: iproc: Validate CSR base in BCMA setup code
PCI: iproc: Set drvdata at end of probe function
PCI: iproc: Add local struct device pointers

I plan to refresh my patches on top of v4.9-rc1 and will send them out once they are done.

Thanks,

Ray

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux