On Thu, Oct 13, 2016 at 01:56:46PM -0400, Murali Karicheri wrote: > On 10/12/2016 12:06 PM, Bjorn Helgaas wrote: > > On Wed, Oct 12, 2016 at 08:53:00AM -0500, Bjorn Helgaas wrote: > >> - Add local "dev" pointers to reduce repetition of things like > >> "&pdev->dev". > >> > >> - Use generic DesignWare accessors when possible. > >> > >> - Pass device-specific struct instead of register addresses to IRQ and > >> DBI functions. > >> > >> - Add app register accessors to encapsulate usage of va_app_base. > >> > >> Nothing here should change the behavior of the driver. > >> > >> Changes from v1: > >> Added local struct device pointers. > >> I dropped the following patch because it was a lot of churn for > >> questionable benefit: > >> PCI: keystone: Name private struct pointer "keystone" consistently > >> > >> --- > >> > >> Bjorn Helgaas (6): > >> PCI: keystone: Add local struct device pointers > >> PCI: keystone: Use generic DesignWare accessors > >> PCI: keystone: Pass keystone_pcie, not address, to IRQ functions > >> PCI: keystone: Pass keystone_pcie, not va_app_base, to DBI functions > >> PCI: keystone: Add app register accessors > >> PCI: keystone: Reorder struct keystone_pcie > >> > >> > >> drivers/pci/host/pci-keystone-dw.c | 123 ++++++++++++++++++++---------------- > >> drivers/pci/host/pci-keystone.c | 28 ++++---- > >> drivers/pci/host/pci-keystone.h | 9 +-- > >> 3 files changed, 88 insertions(+), 72 deletions(-) > > > > I applied these to pci/host-keystone for v4.9. I hope to ask Linus to > > pull them tomorrow, so if you see any issues, let me know soon. > > > Bjorn, > > I have reviewed them and they look good to me. For testing, I am in the > middle of a high visibility debug and it will be a while before I can test > these. Thanks a lot, Murali! No hurry; if I broke something, we can fix it during the rest of the cycle. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
