On Tue, 4 Oct 2016, Sinan Kaya wrote: > The SCI function was removed in two steps (first refactor and then remove). > This patch does the revert in one step. > > The commit 103544d86976 ("ACPI,PCI,IRQ: reduce resource requirements") > refactored the original code so that SCI penalty is calculated dynamically > by the time get_penalty function is called. This patch does a partial > revert for the SCI functionality only. > > The commit 9e5ed6d1fb87 ("ACPI,PCI,IRQ: remove SCI penalize function") is > for the removal of the function. SCI penalty API was replaced by the > runtime penalty calculation based on the value of > acpi_gbl_FADT.sci_interrupt. > > The IRQ type does not get updated at the right time for some platforms and > results in incorrect penalty assignment for PCI IRQs as > irq_get_trigger_type returns the wrong type. > > The register_gsi function delivers the IRQ found in the ACPI table to > the interrupt controller driver. Penalties are calculated before a > link object is enabled to find out which interrupt has the least number > of users. By the time penalties are calculated, the IRQ is not registered > yet and the API returns the wrong type. > > Tested-by: Jonathan Liu <net147@xxxxxxxxx> > Tested-by: Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> > Link: https://lkml.org/lkml/2016/10/4/283 > Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxxxxxx> Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html