On Sun, Sep 25, 2016 at 10:26:24AM +0300, Leon Romanovsky wrote: <...> > > + > > +/* PVRDMA send queue work request */ > > +struct pvrdma_sq_wqe_hdr { > > + __u64 wr_id; /* wr id */ > > + __u32 num_sge; /* size of s/g array */ > > + __u32 total_len; /* reserved */ > > + __u32 opcode; /* operation type */ > > + __u32 send_flags; /* wr flags */ > > + union { > > + __u32 imm_data; > > + __u32 invalidate_rkey; > > + } ex; > > + __u32 reserved; > > + union { > > + struct { > > + __u64 remote_addr; > > + __u32 rkey; > > + __u8 reserved[4]; > > + } rdma; > > + struct { > > + __u64 remote_addr; > > + __u64 compare_add; > > + __u64 swap; > > + __u32 rkey; > > + __u32 reserved; > > + } atomic; > > + struct { > > + __u64 remote_addr; > > + __u32 log_arg_sz; > > + __u32 rkey; > > + union { > > + struct pvrdma_exp_cmp_swap cmp_swap; > > + struct pvrdma_exp_fetch_add fetch_add; > > + } wr_data; > > + } masked_atomics; > > + struct { > > + __u64 iova_start; > > + __u64 pl_pdir_dma; > > + __u32 page_shift; > > + __u32 page_list_len; > > + __u32 length; > > + __u32 access_flags; > > + __u32 rkey; > > + } fast_reg; > > + struct { > > + __u32 remote_qpn; > > + __u32 remote_qkey; > > + struct pvrdma_av av; > > + } ud; > > + } wr; > > +}; > > No, I have half-baked patch series which refactors this structure in kernel. Sorry, this patch series is not needed in kernel. > There is no need to put this structure in UAPI. This is still relevant. Thanks
Attachment:
signature.asc
Description: PGP signature