> I like the idea of this. The part I *don't* like is using kmalloc() > in this path. > > We've always done this, and this patch means we would only do it the > first time for each device, but the struct aer_rpc (which we allocate > for each device at probe time) is over 900 bytes, while the struct > aer_err_info is only about 70 bytes. Why don't we just include > aer_error_info directly in aer_rpc and allocate the whole shebang once > at probe time? I don't really see what we gain by doing the > allocation in the runtime path. Sounds good! Will follow up with a patch -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
