On 8/24/2016 5:39 PM, Bjorn Helgaas wrote: >> Yes, may some pci drivers make a mistake, the refcount control the device object >> > release is fine, but I think move the mem resource release out is better. > If this is caused by driver bugs, I think we need to fix the driver > bugs. > > So far all I see here is "it works when I do this." What we need is > an argument for "it's correct to do this." It's certainly possible > that you're already making that argument and I'm just not > understanding it. > I also want to point out that the sysfs is not the only device removal path. As Bjorn pointed out, you were moving resource free code into the sysfs path and breaking other path (ACPI hotplug). -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
