On Mon, Aug 01, 2016 at 08:53:49AM -0700, Christoph Hellwig wrote: > On Mon, Aug 01, 2016 at 09:57:32AM +0300, Haggai Eran wrote: > > Register the CMB in a gen_pool dedicated to manage CMB regions. Use the > > pool to allocate the SQs to make sure they are registered. > > And why would the NVMe driver care if "they are registered"? > > Once we start allowing diverse CMB uses (what happened to Jon's patches > btw?) genalloc might be a good backend allocator, but without that > it's entirely pointless. Also please don't introduce useless header > files. My concern is using CMB as a generic memory space could lead to invalid uses and untested paths in broken firmware (leading to bricked drives...). The spec defines what it's allowed to be used for, but doesn't really leave it open for general purpose usage outside of that. Because of that I think it needs more hand-holding by the kernel to prevent invalid usage. What I would like to see is a set of knobs controlling the 'chunks' of memory's usages (controlled through sysfs/configfs?) and the kernel takes care of allocation. My set was going to expose a resource file for WDS/RDS but everything else was unhandled except for its current sqes usage. I think the genalloc could fit into this scheme quite well. Thoughts? -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
