Re: [PATCH 3/3] PCI: tegra: Stop setting pcibios_min_mem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 30, 2016 at 03:14:30PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> In practice this value will never be used and it hinders portability of
> the driver, so remove it.
> 
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
>  drivers/pci/host/pci-tegra.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index f04b062e8c67..bbf77a49517d 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -2249,8 +2249,6 @@ static int tegra_pcie_probe(struct platform_device *pdev)
>  	if (err < 0)
>  		return err;
>  
> -	pcibios_min_mem = 0;

unsigned long pcibios_min_mem = 0x01000000;   # arch/arm/mm/iomap.c
#define PCIBIOS_MIN_MEM pcibios_min_mem       # arch/arm/include/asm/pci.h

PCIBIOS_MIN_MEM is used in __pci_assign_resource().

It looks to me like we still use pcibios_min_mem; am I missing something?

>  	err = tegra_pcie_get_resources(pcie);
>  	if (err < 0) {
>  		dev_err(&pdev->dev, "failed to request resources: %d\n", err);
> -- 
> 2.8.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux