On Tue, Jul 12, 2016 at 11:17:54AM +0200, Christoph Hellwig wrote: > > > + dev->irq_affinity = NULL; > > > + > > > + if (rc < 0) > > > return rc; > > > + if (rc < minvec) > > > > else if (rc < minvec) > > No need for the else - the previous line is a return (I've dropped > the removed lines above so that it's clearly visible). And we already > handle the rc == 0 case a few lines above. There is no bug here definitely, but (a) (if my memory serves me well) there are archs whose branch prediction benefits from -else parts in conditionals and (b) the code style you're updating was consistent wrt branching and your change makes it inconsistent even within one function. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
