Re: [PATCH] PCI: export pci_bridge_d3_possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 08, 2016 at 01:54:48AM +0200, Peter Wu wrote:
> Allow the nouveau driver to find out whether the bridge can put itself
> in the D3cold state or whether it should use a specific DSM method to
> achieve the same result.
> 
> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Signed-off-by: Peter Wu <peter@xxxxxxxxxxxxx>
> ---
> Since it is not yet merged in Linus tree, maybe the patch in pci/pm can be
> amended? This is the follow-up patch I had in mind for nouveau:
> 
>     --- a/drivers/gpu/drm/nouveau/nouveau_acpi.c
>     +++ b/drivers/gpu/drm/nouveau/nouveau_acpi.c
>     @@ -223,6 +223,9 @@ static bool nouveau_pr3_present(struct pci_dev *pdev)
>      	if (!parent_pdev)
>      		return false;
>      
>     +	if (!pci_bridge_d3_possible(parent_pdev))
>     +		return false;
>     +

Why not check bridge_d3 directly?

	if (!parent_dev->bridge_d3)
		return false;
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux