[Re: [PATCH 04/14] PCI: generic: make it explicitly non-modular] On 06/07/2016 (Wed 18:02) Will Deacon wrote: > On Sat, Jul 02, 2016 at 07:13:24PM -0400, Paul Gortmaker wrote: > > The Kconfig currently controlling compilation of this code is: > > > > drivers/pci/host/Kconfig:config PCI_HOST_GENERIC > > drivers/pci/host/Kconfig: bool "Generic PCI host controller" > > > > ...meaning that it currently is not being built as a module by anyone. > > > > Lets remove the few trace uses of modular code and macros, so that > > when reading the driver there is no doubt it is builtin-only. > > > > Since module_platform_driver() uses the same init level priority as > > builtin_platform_driver() the init ordering remains unchanged with > > this commit. > > > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > > > We also delete the MODULE_LICENSE tag etc. since all that information > > is already contained at the top of the file in the comments. > > > > Cc: Will Deacon <will.deacon@xxxxxxx> > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > Cc: linux-pci@xxxxxxxxxxxxxxx > > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > > --- > > drivers/pci/host/pci-host-generic.c | 10 ++-------- > > 1 file changed, 2 insertions(+), 8 deletions(-) > > Given that nobody seems to need this as a module and it's not > straightforward to enable that: > > Acked-by: Will Deacon <will.deacon@xxxxxxx> > > I assume you've done something similar for > drivers/pci/host/pci-host-common.c? Not yet -- that one escaped my radar because it didn't have module_init or MODULE_DEVICE_TABLE in it; it just has MODULE_AUTHOR etc. I'll add that fix to my queue and update my audit to hide the MODULE_AUTHOR tags when compiling for !MODULE. Thanks, Paul. -- > > Will -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
