On Mon, Jun 13, 2016 at 05:57:37PM -0400, Keith Busch wrote: > On Mon, Jun 13, 2016 at 05:28:10PM -0400, Keith Busch wrote: > > On Mon, Jun 13, 2016 at 04:14:11PM -0500, Bjorn Helgaas wrote: > > > Can we do that at the same time? If we add good new stuff and only > > > use it one place, there's not as much overall goodness as there would > > > be if we updated everybody to do it similarly. > > > > Sounds good, I'll send a series taking advantage of this for all the > > other PF drivers duplicating this check in their sriov_configure. > > Heh, I thought "no big deal", thinking all use was similar to > NVMe's. However, most network drivers have multiple paths to sriov > configuration, or have other requirements to changing the live > count! There's only two drivers I find that can immediately use the > simplification safely. I'll send those updates to just those ones. My take on that is, "it's a pretty trival check; just put it directly in nvme and don't bother doing anything in the PCI core." Maybe someday we'll come up with a way to make things more common. It doesn't really seem worth it to add something that only helps three drivers. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
