On Mon, 13 Jun 2016 06:33:53 +0000 Ilya Lesokhin <ilyal@xxxxxxxxxxxx> wrote: > > -----Original Message----- > > From: Alex Williamson [mailto:alex.williamson@xxxxxxxxxx] > > Sent: Friday, June 10, 2016 1:22 AM > > To: Ilya Lesokhin <ilyal@xxxxxxxxxxxx> > > Cc: kvm@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; > > Noa Osherovich <noaos@xxxxxxxxxxxx>; Haggai Eran > > <haggaie@xxxxxxxxxxxx>; Or Gerlitz <ogerlitz@xxxxxxxxxxxx>; Liran Liss > > <liranl@xxxxxxxxxxxx> > > Subject: Re: [PATCH 1/4] VFIO: Probe new devices in a live VFIO group with > > the VFIO driver > ... > > > + pdev = to_pci_dev(dev); > > > + if (pdev->driver_override) > > > + kfree(pdev->driver_override); > > > + pdev->driver_override = kstrdup("vfio-pci", GFP_KERNEL); > > > > kstrdup can fail. Probably want to issue a about capturing > > the device as well. Thanks, > > > > Any recommendation as to what I should do in case kstrdup fails? > Fallback to the existing warning ("device added to a live group") ? Probably so. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
