On Wednesday, June 8, 2016 10:21:27 AM CEST Marc Zyngier wrote: > > + rockchip_pcie_enable_interrupts(port); > > + if (!IS_ENABLED(CONFIG_PCI_MSI)) { > > + err = rockchip_pcie_init_irq_domain(port); > > + if (err < 0) > > + goto err_vpcie; > > Why are you excluding wired interrupts if you have PCI_MSI configured? > MSI allocation can fail, and wired interrupts become handy.... Also, a lot of drivers don't do MSI and rely on legacy interrupts. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html