On Tuesday, June 7, 2016 5:17 PM, Thomas Gleixner wrote: > On Tue, 7 Jun 2016, Rui Wang wrote: > > Also simplify the function by removing the redundant 'num' variable. > Please don't do that. This makes the patch hard to read. Split this into a > minimal bugfix, which can be backported and a cleanup patch which gets rid of > the extra variable. > > - ioapics[i].iomem_res = res; > > + ioapics[i].iomem_res = &res[i]; > > If I read the patch correctly, then this is the fix. Right? So please make it > a one liner and send a cleanup patch seperately. Hi Thomas, Yes exactly. I'll send a v2. Thanks Rui -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html