Re: [PATCH v6 0/5] PCI: Add support for suspending (including runtime) of PCIe ports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 02, 2016 at 11:17:10AM +0300, Mika Westerberg wrote:
> Bjorn, if you are fine with these patches, it would be nice to get these to
> linux-next for better testing coverage.
> 
> Changes to v5:
> 
>   - Add patch "PCI: Power on bridges before scanning new devices" to make
>     sure rescanning using sysfs still works.
> 
>   - Change patch "ACPI / hotplug / PCI: Runtime resume bridge before
>     rescan" to runtime resume in acpiphp_check_bridge() instead of
>     hotplug_event().
> 
>   - Change runtime PM autosuspend delay from 10ms to 100ms.
> 
>   - Call pm_runtime_mark_last_busy() to make sure we do not runtime suspend
>     the port immediately.

I've applied v6 of this series to my local tree and tested it with
my Thunderbolt runtime pm patches. Everything seems to still work
fine, so my Tested-by is upheld.

I've also compared this version with the previous one in my tree and
reviewed the changes. I only found a punctuation and spacing change
that Bjorn had made and that isn't included in the commit message of
patch [4/5]:

< hotplug event such as BUS_CHECK, we need to make sure it is resumed before
< devices below the bridge are re-scanned.  Otherwise the devices behind the
---
> hotplug event, such as BUS_CHECK we need to make sure it is resumed before
> devices below the bridge are re-scanned. Otherwise the devices behind the

And this line in the commit message of patch [5/5] suddenly has > 72
chars now:

> Add back runtime PM support for PCIe ports that was removed in
> commit fe9a743a2601 ("PCI/PM: Drop unused runtime PM support code for PCIe

Thanks,

Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux