> -----Original Message----- > From: Lukas Wunner [mailto:lukas@xxxxxxxxx] > Sent: Tuesday, May 24, 2016 13:55 > To: Levy, Amir (Jer) <amir.jer.levy@xxxxxxxxx> > Cc: andreas.noever@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > bhelgaas@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; Jamet, Michael > <michael.jamet@xxxxxxxxx>; Alloun, Dan <dan.alloun@xxxxxxxxx>; > Westerberg, Mika <mika.westerberg@xxxxxxxxx>; Svahn, Kai > <kai.svahn@xxxxxxxxx>; Shevchenko, Andriy > <andriy.shevchenko@xxxxxxxxx>; Winkler, Tomas > <tomas.winkler@xxxxxxxxx> > Subject: Re: [PATCH 0/6] thunderbolt: Introducing Thunderbolt(TM) > networking > > Hi Amir, > > On Mon, May 23, 2016 at 11:48:50AM +0300, Amir Levy wrote: > > Thunderbolt(TM) networking, introduced in these patches, provides the > > capability of connecting hosts together by emulating an Ethernet adapter. > > Thank you for this contribution. I think it may take some time to review > everything, for now just some general observations: > > - Up until now this driver was Mac-only. IIUC the functionality you're > adding will also be used on non-Macs. That's an important change that > should probably be made more explicit in the commit messages. Did you > test your patches on a Mac to see that nothing regresses? Yes, we did some tests on MacBook Pro with Falcon Ridge. Note that (as written in the cover letter), the functionality that we are adding is based on ICM (Intel Connection Manager, firmware). These patches will keep the current functionality on Mac and will add the networking functionality on non-Macs. --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
