Hi Andriy, Hi Amir, On Mon, May 23, 2016 at 10:10:11AM +0000, Shevchenko, Andriy wrote: > On Mon, 2016-05-23 at 11:48 +0300, Amir Levy wrote: > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2618,6 +2618,8 @@ > > #define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_2C_BRIDGE 0x156b > > #define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_4C_NHI 0x156c > > #define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_4C_BRIDGE 0x156d > > > +#define PCI_DEVICE_ID_INTEL_WIN_RIDGE_2C_NHI 0x157d > > +#define PCI_DEVICE_ID_INTEL_WIN_RIDGE_2C_BRIDGE 0x157e > > Are those IDs going to be used somewhere else than one driver? We have a number of Thunderbolt quirks in drivers/pci/quirks.c. Although they do not pertain to Win Ridge right now, it's good to have the list complete. However the list should be sorted numerically, so these should go below Alpine Ridge. I assume Win Ridge is DSL5110, so a comment would be good to signify that it's not Thunderbolt 2 or 3, e.g.: #define PCI_DEVICE_ID_INTEL_WIN_RIDGE_2C_NHI 0x157d /* Tbt 1 Low Pwr */ #define PCI_DEVICE_ID_INTEL_WIN_RIDGE_2C_BRIDGE 0x157e Thanks, Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
